Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move cu24, cu75, cu80/v1 into capsunlocked folder #15758

Merged
merged 2 commits into from
Jan 11, 2022
Merged

move cu24, cu75, cu80/v1 into capsunlocked folder #15758

merged 2 commits into from
Jan 11, 2022

Conversation

peepeetee
Copy link
Contributor

Description

move cu24 and cu75 into capsunlocked folder

move keyboard/cu80 to keyboard/capsunlocked/cu80/v1

Also replaces readme images with imgur links

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@peepeetee
Copy link
Contributor Author

@yiancar @aholland909

@yiancar
Copy link
Contributor

yiancar commented Jan 6, 2022

My PCBs never got used for production.

@peepeetee peepeetee mentioned this pull request Jan 6, 2022
Closed
@peepeetee
Copy link
Contributor Author

My PCBs never got used for production.

Could you elaborate?

@drashna
Copy link
Member

drashna commented Jan 8, 2022 •
edited
Loading

My PCBs never got used for production.

Do you mean that one or more of the boards touched have no production units and can safely be removed?

@yiancar
Copy link
Contributor

yiancar commented Jan 8, 2022

I think so BUT... only CapUnlocked themselves can answer that.

@peepeetee
Copy link
Contributor Author

I think so BUT... only CapUnlocked themselves can answer that.

How should we proceed? since they went insolvent, who should we ask? or should we just .... go forward with the current setup?

drashna
drashna approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, for now, it's in the repo, so I'd say proceed with the assumption that there are units out there.

It may be worth following up with CapsUnlocked to see if there are actual units, and remove them if there are not.

@drashna drashna requested a review from a team January 8, 2022 17:45
@drashna drashna merged commit b1942d1 into qmk:develop Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peepeetee @yiancar @drashna @fauxpark